RH2117972 - Extend the support for NSS DBs (PKCS11) in FIPS mode #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial proposal.
franferrax
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Hi @martinuy, it looks good to me.
NOTE: this PR already includes changes of rh-openjdk/jdk#17 review.
franferrax
requested changes
Nov 30, 2022
There was a problem hiding this comment.
Removing approval, as we need to:
- Backport Add nss.fips.cfg support to OpenJDK tree jdk#22 to this repository, so we can make the
nss.fips.cfgchanges - Apply
f9afab1...69cabe4from RH2117972 - Extend the support for NSS DBs (PKCS11) in FIPS mode jdk#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search this PR in Red Hat Jira
rh-openjdk:fips← THIS PR11u backport of the RH2117972 enhancement. See the 17u PR for further reference: rh-openjdk/jdk#17
Differences with the 17u patch:
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java
src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Token.java
test/jdk/sun/security/pkcs11/fips/NssdbPin.java